fix(cli): surface GraphQL submission lookup failures as read_failed#1493
Open
kiannidev wants to merge 1 commit into
Open
fix(cli): surface GraphQL submission lookup failures as read_failed#1493kiannidev wants to merge 1 commit into
kiannidev wants to merge 1 commit into
Conversation
Stop coercing find_prs_for_issue None sentinel to an empty list so gitt issues submissions --json no longer reports success with zero submissions when GitHub cross-reference lookup fails. Fixes entrius#1492
Collaborator
|
This changes CLI output ( |
Author
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonefrom_search_issue_referencing_prs_graphqlthroughfind_prs_for_issueinstead of coercing to[]Nonefromfetch_open_issue_pull_requestswhen GraphQL lookup failsread_failedJSON error fromgitt issues submissions --jsoninstead of{success: true, submission_count: 0}Related Issues
Fixes #1492
Type of Change
Testing
tests/utils/test_github_api_tools.py—Nonereturned on GraphQL errors / lookup failuretests/cli/test_issue_submission.py—--jsonreturnserror.type == read_failedwhen lookup failsuv run pytest tests/utils/test_github_api_tools.py tests/cli/test_issue_submission.pyChecklist